[FFmpeg-devel] [PATCH 5/5] lavfi: reimplement MPlayer's af_pan filter for libavfilter.
nicolas.george at normalesup.org
Sun Nov 6 17:28:11 CET 2011
Le sextidi 16 brumaire, an CCXX, Clément Bœsch a écrit :
> Since you changed the variable into 'l', you should update the 'n'
> reference here.
Indeed. I reformulated the sentence.
> You should add yourself here now :)
> I'm not familiar enough with fixed point arithmetic; what does the '+'
> stand for?
It is supposed to mean that this is signed arithmetic. But this was a
notation I invented on the spot. I looked up in wikipedia, and the only
notation they give for signedness is "1:7:8", which I adopted.
> Shouldn't this be /256?
Of course. Sorry.
> Does it still work as expected when the number of specified input channels
> doesn't match the actual number of input channels?
It would not have, that was a point that needed discussion. On the
afterthought, I think that the actual number of input channels is more
important than the declared one, and I adapted the code.
It was a small discomfort that filters have no method called after
query_formats, when the filtergraph has decided the various formats.
> Feel free to remove this chunk as well if it works.
> Pointless braces?
I avoid omitting outer braces when the inner block is complex, because I
find it more risky and less readable.
> Anyway, thanks a lot for submitting quickly this patchset.
Thanks to you for the original work.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel