[FFmpeg-devel] [PATCH 2/8] libutvideodec: Replace a silly stay constant
Reimar.Doeffinger at gmx.de
Mon Nov 7 19:34:27 CET 2011
On Mon, Nov 07, 2011 at 01:29:39PM -0500, Derek Buitenhuis wrote:
> On 07/11/2011 1:20 PM, Reimar Döffinger wrote:
> >>That is no good, there is no guarantee how exactly the compiler
> >>> lays it out and thus sizeof(UtVideoExtra) could also be e.g.
> >>> 32 (on an hypothetical architecture that can only read 8 byte
> >>> aligned ints).
> >I see that DecodeBegin already uses it, something seems wrong here.
> Well, then it can just be set to a constant 16.
Thing is, I expect that DecodeBegin might actually expect the unmodified
extradata, i.e. without the endianness conversion we do when reading it
into the struct.
But for that I guess it would be necessary to test on big-endian, unless
someone already has.
And I'd appreciate it if you wouldn't CC me, I get enough mail without
getting everything twice, once in my folder for FFmpeg list mail and once
in my personal mail folder...
More information about the ffmpeg-devel