[FFmpeg-devel] [PATCH]Fix palette calculation in some decoders

Michael Niedermayer michaelni at gmx.at
Fri Nov 11 23:18:03 CET 2011

On Fri, Nov 11, 2011 at 10:44:18PM +0100, Carl Eugen Hoyos wrote:
> Hi!
> If I am not missing something, FFmpeg currently happily assumes complete 
> transparency for most PAL8 codecs.
> I did not find the palette code in vmnc.c, I am unsure if ff_cga_palette[] is 
> correct (black is always transparent?).
> Please comment, I did not test the ones with "AV_RB24()" and 
> "bytestream_get_be24()".
> Thank you, Carl Eugen

The patch looks good but it should be split to make future bisect
also i see several unrelated bugfixes in there, they too should
be split out

otherwise LGTM

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111111/64ea4ade/attachment.asc>

More information about the ffmpeg-devel mailing list