[FFmpeg-devel] [RFC] h264 avoid starting decode on a non top?field

Michael Niedermayer michaelni at gmx.at
Sat Nov 12 21:35:09 CET 2011


On Sat, Nov 12, 2011 at 09:02:19PM +0100, Joakim Plate wrote:
> On Sat, 12 Nov 2011 20:43:47 +0100, Michael Niedermayer wrote:
> 
> > On Sat, Nov 12, 2011 at 07:12:44PM +0000, Joakim Plate wrote:
> >> [17 quoted lines suppressed]
> > 
> > sure, here are some related quotes:
> 
> Found the spec after some searching. And can't say i could find anything
> where it seemed to define any order on decode. I suspect the solution is to
> detect the problem when the second field (that is supposed to be first)
> shows up.

yes


> 
> From what i can tell in the code, it already tries to check the frame_num
> for complementary field pairs. (only if the current one is a reference
> field) I wonder why it doesn't itself there.

droping the reference checks fixes Ticket354 and i havnt spoted a
negative effect of that change

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111112/1761f415/attachment.asc>


More information about the ffmpeg-devel mailing list