[FFmpeg-devel] [PATCH] boxblur: fix huge memleak in end_frame().

[Michael Niedermayer]

On Fri, Nov 25, 2011 at 12:36:27AM +0100, Clément Bœsch wrote:
> On Fri, Nov 25, 2011 at 12:17:15AM +0100, Michael Niedermayer wrote:
> > On Thu, Nov 24, 2011 at 08:45:26PM +0100, Clément Bœsch wrote:
> > > ---
> > > Hi,
> > > 
> > > I have absolutely no idea why this is actually needed here (where are those
> > > buffer "referenced"? isn't it supposed to be free'd by the code allocating
> > > it?), but it seems to fix a huge memleak in this filter. Easily reproducible
> > > with something like: ./ffplay -f lavfi mandelbrot,boxblur=2:2; ~50MB/sec lost
> > > here.
> > 
> > As the filter uses the default start frame, the cleanup done by the
> > default end frame is needed.
> > 
> 
> Ah, that makes much more sense to me indeed. Please commit with this
> comment, that's what I missed :)

locally commited, ill push later

[...]



-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111125/2b539dab/attachment.asc>