[FFmpeg-devel] ffplay: fix order of operations for sdl audio open
michaelni at gmx.at
Sat Oct 1 22:16:21 CEST 2011
On Sat, Oct 01, 2011 at 10:07:33PM +0200, Michael Niedermayer wrote:
> On Sat, Oct 01, 2011 at 09:41:00PM +0200, Marton Balint wrote:
> > Hi,
> > The patch in the subject (3715e675) seems broken in some ways:
> > - The sample rate / channel count sanity check is not against the
> > actually used sample rate / channel count.
> > - Avctx->request_channels can affect the number of the channels,
> > therefore downmixing of 5.1 audio to stereo (default for ffplay)
> > currently does not work because of the patch.
> > Isn't the aac decoder should be fixed instead of ffplay to return
> > the proper number of channels after calling avcodec_open2?
> The aac decoder in this bug has incorrect extradata that lists a wrong
> channel number, i saw no way it could detect this easily.
Note, simply not passiing extradata from rtsp/rtp may be an option but
this too may break something
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel