[FFmpeg-devel] [PATCH] Add libmodplug support.

[Clément Bœsch]

On Tue, Oct 04, 2011 at 10:08:20PM +0200, Michael Niedermayer wrote:
> On Tue, Oct 04, 2011 at 09:21:38PM +0200, Clément Bœsch wrote:
> > On Tue, Oct 04, 2011 at 09:11:36PM +0200, Clément Bœsch wrote:
> > > ---
> > >  Changelog                |    1 +
> > >  MAINTAINERS              |    1 +
> > >  configure                |    5 ++
> > >  libavformat/Makefile     |    1 +
> > >  libavformat/allformats.c |    3 +
> > >  libavformat/libmodplug.c |  110 ++++++++++++++++++++++++++++++++++++++++++++++
> > >  libavformat/version.h    |    2 +-
> > >  7 files changed, 122 insertions(+), 1 deletions(-)
> > >  create mode 100644 libavformat/libmodplug.c
> > > 
> 
> the patch looks very nice

Thanks :)

> i suggest to commit it and improve it afterwards like making that 5M
> limit user selectable
> 

OK, I'll push in a moment. About the 5M limit, this is indeed not very
sexy, but looking at the ~2500 keygen music, the bigger one is less than
3M (IIRC).

Another way would be to do sth like:

    #if HAVE_MMAP
    fd = open...
    mmap(...)
    #else
    // fallback fixed limit size
    #endif

But it is quite a pain to workaround the libmodplug API, and IMO not worth
it because of what I said above. A higher limit can indeed be added to
options when I'll add them.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111004/dd8ded47/attachment.asc>