[FFmpeg-devel] [PATCH] ffplay: Update input_get_buffer() to match avcodec_default_get_buffer()

[Michael Niedermayer]

On Thu, Oct 06, 2011 at 01:14:17PM +0200, Michael Niedermayer wrote:
> On Thu, Oct 06, 2011 at 11:13:48AM +0200, Nicolas George wrote:
> > Le quintidi 15 vendémiaire, an CCXX, Michael Niedermayer a écrit :
> > > Subject: [PATCH] ffplay: Update input_get_buffer() to match avcodec_default_get_buffer()
> > 
> > Shouldn't the same change be made to reget_buffer? It is not done in
> > lavc/utils.c, but it seems wrong.
> > 
> > Maybe a common function would be a good thing:
> > 	avcodec_init_buffer_info(avctx, pix)
> > ?
> 
> I think even better would be below + updating all decoders
> the advanatge would be that applications would not need to be chnaged
> nor have to deal with extra complexity and yet another function
> 
> int avcodec_get_buffer(AVCodecContext *s, AVFrame *pic, int reget, int reference){

Iam going to add this function later today unless there is someone
screamin "stop, i have a better idea"

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111006/0fc76aff/attachment.asc>