[FFmpeg-devel] Suggestion: limit deshake to specific area to search for motion vectors.

Michael Niedermayer michaelni at gmx.at
Wed Oct 19 23:51:09 CEST 2011

On Wed, Oct 19, 2011 at 09:49:37PM +0100, Paul Flinders wrote:
> On 10/19/2011 05:57 PM, Michael Niedermayer wrote:
> >-    deshake->refcount = 20;
> >+    deshake->refcount = 10;
> >+
> >this change looks unrelated, also theres trailing whitespace and tabs
> >(which arent allowed in ffmpeg git)
> Ah yes - I was trying to figure out the practical affect of changing
> the refcount but it's not adjustable in the filter arguments.
> >I think there is insufficient validation of the c* values
> Agreed, however it was intended more as proof-of-concept for
> discussion rather than a fully worked up patch.

Iam not sure what could be discussed on this ?
making the values parametric using libavutil/eval maybe but this could
be a seperate patch afterwards too
Also one could support using some mask image that "lists" what should
be used and what not but thats not the same as a simply specifyable
thus once you removed all the tabs i think the patch is close to
being ok.

Further improvments are of course possible and welcome!


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There seems to be only one solution to NIH syndrom, ... a shooting squad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111019/e75a71b5/attachment.asc>

More information about the ffmpeg-devel mailing list