[FFmpeg-devel] [PATCH] gxf: add timecode information to metadata

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Oct 28 00:18:47 CEST 2011

Don't have time to fully review, but:

On Thu, Oct 27, 2011 at 10:04:37PM +0200, Matthieu Bouron wrote:
> @@ -341,8 +388,10 @@ static int gxf_header(AVFormatContext *s, AVFormatParameters *ap) {
>          if (len >= 0x39) {
> +            len -= 0x51;

These do not go together.
I do not know if the UMF packet is actually required to be that large,
but even if it is I'm not sure I like the idea of requiring that,
considering how broken a lot of (if not most) files are.

More information about the ffmpeg-devel mailing list