[FFmpeg-devel] [PATCH 1/2] Parse MXF partitions

[Michael Niedermayer]

On Wed, May 18, 2011 at 09:39:30AM +0200, Tomas Härdin wrote:
> Baptiste Coudurier skrev 2011-05-17 18:00:
>> Hi Tomas,
>>
>> On 05/17/2011 07:44 AM, Tomas Härdin wrote:
>>> Forked from the thread "[PATCH] MXF index table based seeking" to avoid
>>> cluttering the original thread up.
>>>
>>> Baptiste Coudurier skrev 2011-05-17 05:31:
>>>>>    typedef struct {
>>>>> +    MXFPartition **partitions;
>>>>> +    unsigned partitions_count;
>>>>
>>>> Any reason you don't use MXFPartition *partitions ?
>>>> It avoids malloc for each partition.
>>>
>>> No reason at all. Reworked.
>>>
>>>>> [...]
>>>>>
>>>>> +
>>>>> +    /* consider both footers to be closed (there is only Footer and
>>> CompleteFooter) */
>>>>> +    partition->closed = partition->type == Footer || !(uid[14]&   1);
>>>>
>>>> Do we really need to workaround here ?
>>>
>>> Not really a workaround, just a statement of fact. There's no such thing
>>> as OpenFooter, hence we might as well set closed correctly.
>>
>> Patch ok, feel free to apply it when you want.
>
> I'm on a Windows machine atm, so you could apply it for now. I suppose I  
> could mail in the SSH key for my virtual ubuntu machine, but I'd do that  
> later.

It seems this was forgotten, ive applied & pushed it now
thanks for the patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110902/3010bdff/attachment.asc>