[FFmpeg-devel] [PATCH] Remove noise message from MP3 decoder

Nicolas George nicolas.george at normalesup.org
Wed Sep 7 12:54:49 CEST 2011


Le primidi 21 fructidor, an CCXIX, Chris Rankin a écrit :
> Digging further, I discovered that the MP3 decoder in libavcodec
> will always print this message whenever it is handed a packet with
> more than one frame in. There are a number of problems with this:
> 
> a) This isn't an error. The audio stream plays fine.
> b) AV_LOG_ERROR is supposed to be reserved for "Something went wrong
> and cannot losslessly be recovered". However, the situation *is*
> "recovered" from without loss.
> c) avcodec_decode_audio3() is documented as accepting an AVPacket.
> But if an AVPacket can legitimately contain multiple frames then why
> is the MP3 decoder complaining about it in the first place?
> 
> I've attached two alternative patches for this: one (my preferred
> solution) just removes the error message entirely. The second
> demotes the message to DEBUG level instead, just in case someone
> might actually want to see it. (I can't imagine why, though.)

I believe the patch is theoretically correct, but I wonder in what situation
you hit the problem. It may be that the multiple frames in a packet is
caused by a demuxer problem. Could you provide a sample file showing the
issue?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110907/c5a05e63/attachment.asc>


More information about the ffmpeg-devel mailing list