[FFmpeg-devel] [PATCH] flvdec: Remove AVFMTCTX_NOHEADER when there is only 1 stream

Michael Niedermayer michaelni at gmx.at
Wed Sep 7 13:38:22 CEST 2011

On Wed, Sep 07, 2011 at 12:22:19PM +0100, Asad Mehmood wrote:
> On 7 September 2011 12:08, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, Sep 07, 2011 at 11:07:56AM +0100, Asad Mehmood wrote:
> > this seems missing a check that there is actually one stream and not
> > 0
> The code should only be called when there is 1 stream ...
> If the flags claim there to be 0 streams flvdec will assume there to
> be 2 streams
> and acodec and vcodec will not be null.

true, but i actually think ive seen this misbehave. So theres some
chance this might change
thus i would feel better the code actually checks there is one stream
because if this case becomes possible, iam sure people would forget
updating the check.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110907/914b1f54/attachment.asc>

More information about the ffmpeg-devel mailing list