[FFmpeg-devel] [PATCH 4/9] Don't assume reading more frames in av_find_stream_info will change a CODEC_ID_NONEinto something better

Michael Niedermayer michaelni at gmx.at
Sun Sep 11 18:59:46 CEST 2011

On Sun, Sep 11, 2011 at 03:55:26PM +0200, Joakim Plate wrote:
> On Sat, 10 Sep 2011 21:35:27 +0000 (UTC), Joakim Plate wrote:
> > Ah okey, then that aught to be checked instead. Will update patch.
> > The reason was it made av_find_stream_info read a pointless amount
> > of the stream.
> Okey, this is more of an RFC. It's not tested against the situation that
> was the reason for the first patch. (I can't seem to remember what sample
> file i used to track it down).
> The issue was nothing major, it was just wasting time in
> av_find_stream_info which was explicitly noticable if you played a live
> stream wich has limited throughput. 
> The thought here is that, if we are not probing and have CODEC_ID_NONE. We
> won't get any more codec information than we already have.
> /Joakim

>  utils.c |   15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> f434447bf23690de96d444164c630e3e3e6d6b91  0002-Don-t-assume-reading-more-frames-in-av_find_stream_i.patch
> From a9dff6398b7ae5c6a2745a82d531fca139ddfe35 Mon Sep 17 00:00:00 2001
> From: Cory Fields <theuni-nospam- at xbmc.org>
> Date: Mon, 28 Jun 2010 22:46:49 -0400

> Subject: [PATCH 2/4] Don't assume reading more frames in av_find_stream_info
>  will change a CODEC_ID_NONE into something better

i am leaning slightly toward applying this patch as it makes sense but
the commit message needs to be updated

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110911/d20d5304/attachment.asc>

More information about the ffmpeg-devel mailing list