[FFmpeg-devel] [PATCH 3/3] lavfi: fix doxygen doc for AVFilterLink.time_base
michaelni at gmx.at
Fri Sep 16 15:47:30 CEST 2011
On Fri, Sep 16, 2011 at 11:55:27AM +0200, Stefano Sabatini wrote:
> On date Monday 2011-09-12 03:05:59 +0200, Michael Niedermayer encoded:
> > On Sun, Sep 11, 2011 at 01:47:29PM +0200, Stefano Sabatini wrote:
> > > Subject: [PATCH] lavfi: drop AVFilterLink.sample_rate at the next major bump
> > >
> > > Use time_base instead for storing such information.
> > >
> > > This avoids duplication of information, and simplifies PTS handling for
> > > the unified API, as time_base can be used for computing both audio and
> > > video buffers timestamps.
> > iam ok with this, just one note to make sure we dont by mistake run in
> > an issue with it
> > mpeg-ps has a timebase of 90khz and samplerates of 44.1,48,22.05, ...
> > that means if we want to preserve this through the filter chains
> > (and i dont know if we want or dont want...)
> > then we need both timebase & sample_rate
> > otoh i dont mind at all to drop that extra complexity and use a
> > timebase equal to the samplerate
> Uhm, no strong opinion on this, in general timebase can be different
> from 1/samplerate, so I'm not against keeping both fields if it makes
> sense (does it?).
no strong oppinon here either, and iam not sure if it makes sense or
not, thats why i brought it up.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
You can kill me, but you cannot change the truth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel