[FFmpeg-devel] [PATCH] libx264: restore call to check_default_settings

Michael Niedermayer michaelni at gmx.at
Wed Sep 28 15:15:52 CEST 2011

On Sun, Sep 25, 2011 at 02:38:50PM +0200, Nicolas George wrote:
> Hi.
> It seems this hunk was lost during the merge
> f1b5693027d48a9e448f21595fb9247893c225cf, leaving the check_default_settings
> function orphaned.
> I only have an approximate idea of what that function does, and no test case
> for it. But as it is, the code with an unused static function is obviously
> wrong.

I dont think this function makes all that much sense anymore
Ive removed it locally and will push that unless i hear objections
soon (and not a big issue we can put it back if a need is later found)

> Baptiste, as the original author of the code, you may want to look at it.

in CC

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110928/fd487115/attachment.asc>

More information about the ffmpeg-devel mailing list