[FFmpeg-devel] [PATCH] Per-frame metadata

Michael Niedermayer michaelni at gmx.at
Wed Sep 28 17:54:04 CEST 2011

On Fri, Jun 10, 2011 at 08:47:51PM +0200, Nicolas George wrote:
> Hi. After the recent move of the metadata API to libavutil, I rebased and
> reworked my proposal for per-frame metadata decoding:
> 1/5: Introduce av_size_mult and av_realloc_f
> This is very similar to the original proposal. The chunk with av_size_mult
> was ok-ed, but was later changed to return an AVERROR code rather than -1.
> I also learned in the meantime that BSD has a reallocf function, which is
> similar to the proposed av_realloc_f: it frees the memory if it fails, but
> it does not check for integer overflow.

split & applied

> 2/5: Replace av_realloc by av_realloc_f when relevant
> Unchanged except for merge conflicts.

split & applied except most FIXMEs, they imho should be fixed instead
of documented

rest of the series still pending more review


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110928/4db696b5/attachment.asc>

More information about the ffmpeg-devel mailing list