[FFmpeg-devel] [PATCH 2/3] vf_drawtext: use drawutils.

Nicolas George nicolas.george at normalesup.org
Wed Apr 4 16:41:47 CEST 2012

Le quartidi 14 germinal, an CCXX, Stefano Sabatini a écrit :
> nit+: dc->draw looks more readable/consistent

There was already a field named draw in the context. Feel free to rename
anything the way you want.

> Looks fine otherwise, great work.

Pushed, thanks for the review.

> Note: a drawtext test would be useful at some point.

That would require the same font to be always available, identical.

Or we could embed a default font in libavfilter. A quick test with Fontforge
shows that the ASCII glyphs from FreeSans amount to less than 10k of data,
compared to 560+k for libavfilter itself.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120404/61cfd93d/attachment.asc>

More information about the ffmpeg-devel mailing list