[FFmpeg-devel] [PATCH] ffprobe: use avbprint API

Stefano Sabatini stefasab at gmail.com
Sun Apr 8 00:10:57 CEST 2012


On date Saturday 2012-04-07 17:20:27 +0200, Nicolas George encoded:
> Le nonidi 19 germinal, an CCXX, Stefano Sabatini a écrit :
> > Simplify, increase robustness.
> > ---
> >  ffprobe.c |  265 +++++++++++++++++++------------------------------------------
> >  1 files changed, 81 insertions(+), 184 deletions(-)
> 
> It looks correct.
> 
> Some code could probably be factored, but this is completely unrelated.
> 
> > +    for (p = src; *p; p++) {
> >          if (*p == '"')
> > -            *q++ = '\"';
> > -        *q++ = *p++;
> > +            av_bprint_chars(dst, '\"', 1);
> 
> For CSV, shouldn't \ itself be escaped too? This is unrelated too, though.

Thanks for the review, pushed.
-- 
FFmpeg = Fabulous and Foolish Miracolous Peaceless Elected Gorilla


More information about the ffmpeg-devel mailing list