[FFmpeg-devel] [PATCH] latmenc: remove dead code.
kierank at ob-encoder.com
Mon Apr 9 18:06:01 CEST 2012
> But even giving up on the ALS case issues abound: the number of
> bits between the position the header parser returns and the pce
> data can be variable, the code assumes it is always 3 (and
> even that only after fixing it, otherwise it assumes the pce is
> at the start of extradata, which is just nonsense).
> Now after all that is fixed, there is the issue of bitstream
> modifications, and all I did was hack the userdata stuff to work.
> The only reason I did that is that testing the muxer is kind of
> hard when not a single of our FATE samples actually works with it.
I agree the ALS special case is broken. If you really want to fix the
part, why not add a function in mpeg4audio that gives you the pce
offset? That said,
I don't think we allow any of the AOTs that use core coders anyway so
as far as I'm concerned
your offset of 3 bits is correct.
I guess it's ok to modify the bitstream in latm as long as it's
explained because latm
is the only format where the payload is not written byte aligned.
More information about the ffmpeg-devel