[FFmpeg-devel] [PATCH]Fix MPEG-2 decoding of interlaced streams with hwaccel

Hendrik Leppkes h.leppkes at gmail.com
Tue Apr 10 10:03:14 CEST 2012

On Tue, Apr 10, 2012 at 7:51 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Hi!
> Attached patch fixes MPEG-2 interlaced decoding with hwaccel.
> The accelerator needs to decode the field pictures when they are complete,
> in
> case of an error, the function returns -1.

Directly in the block above is already a call to hwaccel->end_frame (under
a condition).
Adding an unconditional call just below it seems pointless. Either instruct
everyone to use that flag to trigger the above call, or just remove the
condition, but adding a second block is just wrong.
I just set the flag in my implementation and everything decodes just fine

Erroring out on failure also seems to cause other problems, because the
start_frame for the next frame is also skipped then. I would just log the
error but ignore it.

- Hendrik

More information about the ffmpeg-devel mailing list