[FFmpeg-devel] [PATCH] lavf: always call avio_flush in av_write_trailer.

Michael Niedermayer michaelni at gmx.at
Wed Apr 11 01:41:14 CEST 2012

On Tue, Apr 10, 2012 at 09:38:06PM +0200, Reimar Döffinger wrote:
> Otherwise for muxers like e.g. latmenc that never call
> avio_flush (and do not have a write_trailer function)
> a part of the data will always be missing.
> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>

LGTM (if it passes fate)

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120411/69ffebfa/attachment.asc>

More information about the ffmpeg-devel mailing list