[FFmpeg-devel] [PATCH] mov: Fix memory leaks on aborted header parsing.

Dale Curtis dalecurtis at chromium.org
Fri Apr 13 19:06:53 CEST 2012


On Fri, Apr 13, 2012 at 3:10 AM, Michael Niedermayer <michaelni at gmx.at>wrote:

> On Thu, Apr 12, 2012 at 05:50:55PM -0700, dalecurtis at chromium.org wrote:
> > From: Dale Curtis <dalecurtis at chromium.org>
> >
> > If mov_read_header exits under error, the memory allocated is
> > not freed.
> >
> > Signed-off-by: Dale Curtis <dalecurtis at chromium.org>
>
> i wonder if we can simply call the close for all demuxers in utils.c,
> as this likely affects more demuxers
> but until thats tested and investigated, ill apply this patch.
>
> thanks
>
>
FWIW, closing for all demuxers in utils was the patch I made locally for
Chrome last time, I ran into several double-free's just in the codecs we
are using though so never tried to upstream it. All the leaks that method
fixed seem fixed elsewhere in master now.

- dale


More information about the ffmpeg-devel mailing list