[FFmpeg-devel] [PATCH] Fixed missing error handling in yadif poll_frame

[Michael Niedermayer]

On Sat, Apr 14, 2012 at 08:36:22PM +0200, Robert Nagy wrote:
> Fixed patch.

>  vf_yadif.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> aeb1159b71654beda9c93dbf221815aed2f8ce20  0001-Fixed-missing-error-handling-for-yadif-poll_frame.patch
> From c5f12f93945f994385be05f6feb04176cc5a6a0a Mon Sep 17 00:00:00 2001
> From: Robert Nagy <ronag89 at gmail.com>
> Date: Sat, 14 Apr 2012 20:34:37 +0200
> Subject: [PATCH 1/2] Fixed missing error handling for yadif poll_frame.
> 
> ---
>  libavfilter/vf_yadif.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/libavfilter/vf_yadif.c b/libavfilter/vf_yadif.c
> index 4ade615..548ee9e 100644
> --- a/libavfilter/vf_yadif.c
> +++ b/libavfilter/vf_yadif.c
> @@ -314,11 +314,13 @@ static int poll_frame(AVFilterLink *link)
>          return 1;
>  
>      val = avfilter_poll_frame(link->src->inputs[0]);
> +    if(val <= 0)
> +	     return val;

tabs arent allowed in ffmpeg git


>  
>      if (val >= 1 && !yadif->next) { //FIXME change API to not requre this red tape

>          if ((ret = avfilter_request_frame(link->src->inputs[0])) < 0)
>              return ret;
> -        val = avfilter_poll_frame(link->src->inputs[0]);
> +        return poll_frame(link->src->inputs[0]);

this doesnt look right
link->src->inputs[0] doesnt need to be a yadif filters output link, yet
yadifs poll_frame() expects to be called on a output link of yadif

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120415/52bdf7a4/attachment.asc>