[FFmpeg-devel] [PATCH] Fixed missing error handling in yadif poll_frame

Nicolas George nicolas.george at normalesup.org
Sun Apr 15 16:20:09 CEST 2012

Le septidi 27 germinal, an CCXX, Robert Nagy a écrit :
> The problem I have with the current implementation is that I
> cannot propagate AVERROR_EOF through the filter without triggering the
> assertion.

Propagate AVERROR_EOF from where to where?

If you are writing a new application, I strongly advise you to avoid using
poll_frame at all: only use request_frame, and we will make sure it does
propagate AVERROR_EOF.

I do not mind fixing poll_frame in yadif or anywhere else, but my goal is to
remove it from all filters eventually, so adding complexity to it would be
wasted effort. But since the effort is already done, it does not matter

Also, note that I do not know yadif enough to be sure that your last patch
is correct or not. Someone with more knowledge in that area need to look at


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120415/30553cb7/attachment.asc>

More information about the ffmpeg-devel mailing list