[FFmpeg-devel] [PATCH] web: Copy FFmpeg Logo by Makefile instead of cronjob
Reimar.Doeffinger at gmx.de
Mon Apr 16 21:51:23 CEST 2012
On 16 Apr 2012, at 17:36, Thilo Borgmann <thilo.borgmann at googlemail.com> wrote:
> Am 14.04.12 18:05, schrieb Reimar Döffinger:
>> On Sat, Apr 14, 2012 at 11:46:03AM +0200, Michael Niedermayer wrote:
>>> On Wed, Apr 11, 2012 at 12:50:34PM +0200, Thilo Borgmann wrote:
>>>>> this will update teh file even if it matches, this breaks caching of
>>>>> the logo
>>>> Updated Patch attached.
>>> from a quick look, its ok
>>> maybe reimar can double check ?
>> I don't see any real issues with it.
>> Though if you're pedantic there's a questions whether "test -r" is
>> the best condition, copying over the file to my knowledge won't
>> fix any permissions which is why I went with -f originally.
>> I don't think it really matters, when it makes a different things
>> are already seriously broken anyway and will need manual intervention.
> I don't really get it.
> "test -r" or "test -f" - what does that have to do with fixing permissions?
What is the point of overwriting the file when the problem is that the file exists but is not readable, when that will be the case afterward still?
That's why I chose -f since it avoids pointlessly copying, but as said I think it doesn't matter really.
More information about the ffmpeg-devel