[FFmpeg-devel] [PATCH 2/3] parseutils: make av_parse_time() check for failure.

Nicolas George nicolas.george at normalesup.org
Mon Apr 23 00:34:33 CEST 2012

Le quintidi 5 floréal, an CCXX, Stefano Sabatini a écrit :
> Looks good to me, assuming it has been tested,

Testing was the point of patch 3/3: all the tests results are unchanged by
this patch except for "12:34 -> error", which is precisely what I wanted to

Do you see cases I forgot?

>						 although the changes
> could be split to make the patch more readable.

I do not think this can easily be done: to be able to check for error, I had
to move two pieces of the parsing from a place to another, and most of the
differences come from there.

I will try to rebase and push this set tomorrow if there are no more

Thanks for the review.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120423/0f23c78e/attachment.asc>

More information about the ffmpeg-devel mailing list