[FFmpeg-devel] [PATCH] h264: assembly version of get_cabac for x86_64 with PIC (v5)
rscheidegger_lists at hispeed.ch
Mon Apr 23 13:13:20 CEST 2012
Am 21.04.2012 20:47, schrieb Reimar Döffinger:
> On Sat, Apr 21, 2012 at 05:51:22PM +0200, Roland Scheidegger wrote:
>> + int *rip;
> Why int * and not void *?
You're right that's cleaner.
> Also, tailing whitespace.
I'll fix that.
>> - "movzbl "MANGLE(last_coeff_flag_offset_8x8)"(%k6), %k6\n\t"
>> +#ifdef BROKEN_RELOCATIONS
>> + "movzbl "LABEL_MANGLE(last_coeff_flag_offset_8x8)"-1b(%14, %q6), %k6\n\t"
>> + "movzbl "LABEL_MANGLE(last_coeff_flag_offset_8x8"(%k6), %k6\n\t"
> Why did you change the else case? Besides the missing ) I don't think
> it's correct to use LABEL_MANGLE for that one.
I missed the bracket indeed (mistakenly removed the mangle initially).
As for LABEL_MANGLE vs. MANGLE I can change it back. LABEL_MANGLE is
only different from MANGLE in case of ARCH_X86_64 && defined(PIC) (which
equals BROKEN_RELOCATIONS) hence it doesn't really matter, I don't know
which one is "more correct" but I'll change it back.
More information about the ffmpeg-devel