[FFmpeg-devel] [PATCH] Fix nonsense non-mod16 AMV flipping code.
Reimar.Doeffinger at gmx.de
Sun Apr 29 21:04:01 CEST 2012
On Sun, Apr 29, 2012 at 08:55:31PM +0200, Michael Niedermayer wrote:
> On Sat, Apr 28, 2012 at 11:37:08PM +0200, Reimar Döffinger wrote:
> > It is obviously nonsense since it produces wrong results
> > or even crashes (crashes should be encode-only though).
> > Fixes trac issue #1092.
> can someone verify some %16 =! 0 and %8 != 0 files before and after
> this change on a real AMV device ?
Definitely a good idea, however that the old code is nonsense should
become obvious if you insert a height of 15, that would leave the
data pointers unchanged and invert the stride, i.e. only a single line
of the image area would be used.
_Subtracting_ the height % 15 just makes no sense whatsoever, though
it happens to be almost right for % 8 == 0.
More information about the ffmpeg-devel