[FFmpeg-devel] [PATCH] assdec: return EOF instead of EIO.
ubitux at gmail.com
Thu Aug 2 14:10:38 CEST 2012
On Thu, Aug 02, 2012 at 11:30:39AM +0200, Nicolas George wrote:
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> libavformat/assdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> Maybe it could be converted to FFDemuxSubtitlesQueue, but that is another
Yes I emitted that request a while ago, and I believe that would be a good
thing. It will require to test & port read_seek2() callback, which could
be used in all the other sub formats using FFDemuxSubtitlesQueue.
BTW, I have no idea how I am supposed to test the seek callback.
That said, I don't have time for this now anyway...
> diff --git a/libavformat/assdec.c b/libavformat/assdec.c
> index 6295888..6229857 100644
> --- a/libavformat/assdec.c
> +++ b/libavformat/assdec.c
> @@ -147,7 +147,7 @@ static int read_packet(AVFormatContext *s, AVPacket *pkt)
> uint8_t *p, *end;
> if(ass->event_index >= ass->event_count)
> - return AVERROR(EIO);
> + return AVERROR_EOF;
LGTM, does it solve any real issue?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 490 bytes
Desc: not available
More information about the ffmpeg-devel