[FFmpeg-devel] [PATCH] lavf/img2dec: document and amend logic in find_image_range()
stefasab at gmail.com
Sat Aug 4 18:41:30 CEST 2012
On date Saturday 2012-08-04 16:00:29 +0200, Michael Niedermayer encoded:
> On Sat, Aug 04, 2012 at 01:22:27PM +0200, Stefano Sabatini wrote:
> > Also rename the parameter max_start to start_index, which seems more
> > consistent with the assumed logic.
> > "start_index" represents the minimum accepted value for the first index,
> > and not the maximum value as implicitely assumed by the parameter name.
> > Also we require the start index to start from 1, in order not to break
> > compatibility with the behavior predating the start_number option
> > addition.
> > ---
> > libavformat/img2dec.c | 23 ++++++++++++++++-------
> > 1 files changed, 16 insertions(+), 7 deletions(-)
> please seperate variable renaming from functional changes
> it makes the patch harder to read and also would be more annoying if
> we ended up on this commit in a git bisect
Dropped in favor of newly posted patches.
FFmpeg = Freak & Faithful Mystic Political Encoding/decoding Gorilla
More information about the ffmpeg-devel