[FFmpeg-devel] [PATCH] lavf/img2dec: add -pattern_type option

Stefano Sabatini stefasab at gmail.com
Wed Aug 8 01:17:11 CEST 2012

On date Wednesday 2012-08-08 00:26:18 +0200, Alexander Strasser encoded:
> Stefano Sabatini wrote:
> > + at var{pattern_type} can assume one of the following values.
> nit: Not fully sure but "can assume" sounds a bit strange to my
> non-native English ears.
>   Quick list of alternatives that come to mind:
> "accepts", "can be", "can take", "can be set to"

=> accepts

> [...]
> > + at item glob_sequence
> > +Select a mixed glob wildcard/sequence pattern.
>   If we really want to remove glob_sequence, then it is probably
> a good idea to mention it here too.
>   Maybe
>   @item glob_sequence (deprecated, will be removed)
> or similar.

It is already mentioned at the end of the paragraph, but I added an
@emph warning right after the @item entry.

> [remaining patch snipped]
>   The remaining parts look good AFAICT. I could not quickly test
> as the patch doesn't apply cleanly for me. But assuming it works
> for you and you tested it I would say it is push-ready (maybe
> wait a little bit longer if someone else wants to comment).

Patch updated, will push it in one day or so if I read no more
FFmpeg = Formidable & Foolish Miracolous Pure Ecumenical Gadget
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-doc-ffmpeg-do-not-show-examples-making-use-of-the-de.patch
Type: text/x-diff
Size: 2251 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120808/77a94d9f/attachment.bin>

More information about the ffmpeg-devel mailing list