[FFmpeg-devel] checkheaders post today's merge
jamrial at gmail.com
Thu Aug 9 04:34:38 CEST 2012
On 08/08/12 10:55 PM, Michael Niedermayer wrote:
> On Wed, Aug 08, 2012 at 09:10:18PM -0300, jamal wrote:
>> Today's merge broke checkheaders. Niedermayer forgot to apply a change to common.mak that in quatar goes in Makefile.
>> To make things worse this came right after my out-of-tree folder creation fix and uses conflicting names (HOBJS instead of HEADEROBJS). Curious how Rullgard's change was committed to quatar literally two minutes after Hoyos committed mine.
> i appologize for missing this hunk. It will be fixed in my next git
No need to apologize, I just pointed the part you missed.
>> The fix is simple, apply the missing change to common.mak and rename HEADEROBJS to HOBJS. As a plus this can reduce the difference with quatar by about four lines if we realign the $(sort $(dir)) lines to the way they were before my patch.
>> Should i submit a patch for this or does someone else want to do it instead?
> please submit a patch, or if you prefer, iam also happy to merge
> from some public git repo if you have one with this fix ...
Sure, I'll send a patch in a moment.
More information about the ffmpeg-devel