[FFmpeg-devel] [PATCH 1/2] vda: decode frame synchronously.
michaelni at gmx.at
Thu Aug 9 19:52:05 CEST 2012
On Thu, Aug 09, 2012 at 09:39:10AM +0200, Sebastien Zwickert wrote:
> On Aug 9, 2012, at 4:42 AM, Michael Niedermayer wrote:
> > On Tue, Aug 07, 2012 at 09:46:46PM +0200, Sebastien Zwickert wrote:
> >> From: Sebastien Zwickert <dilaroga at free.fr>
> >> The current implementation of VDA uses the default mode: the hardware decoder is running
> >> asynchronously, that's why the HWAccel VDA must manage its own queue and then depends
> >> on pthreads. The client needs to wait until the queue is not empty in order to start
> >> processing the decoded frame. In VLC, there's a short flicker at the beginning of every
> >> movies and when we seek in movies due to this asynchrone mode.
> >> These changes uses the hardware decoder synchronously so that VDA module is now able to
> >> return the decoded frame into the corresponding frame's data. Thus, the queue and its
> >> glue code become needless just like the pthreads dependency.
> >> But this patch removes a public struct and some public functions relative to the
> >> management of the queue so I bumped the minor version number.
> > This sounds possibly problematic
> > is anything using these removed things ?
> > consider vlc being linked to libavcodec.so.123
> > if the user updates libavcodec and vlc uses a removed symbol vlc might
> > not work anymore (depends also on how the symbol is used ...)
> Keep the both implementations together and mark the symbols this patch remove
> as deprecated in order to drop them at a future version dump is an acceptable solution ?
You are the maintainer, its completely your choice, but yes this
should work fine
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel