[FFmpeg-devel] [PATCH] lavfi: add avfilter_get_class() and iteration callbacks

Stefano Sabatini stefasab at gmail.com
Mon Aug 13 00:08:05 CEST 2012


On date Sunday 2012-08-12 14:22:22 +0200, Michael Niedermayer encoded:
> On Sun, Aug 12, 2012 at 12:10:50PM +0200, Stefano Sabatini wrote:
[...]
> >  avfilter.c |   35 +++++++++++++++++++++++++++++++++++
> >  avfilter.h |    6 ++++++
> >  2 files changed, 41 insertions(+)
> > 7dfb67b9e94d9337949d59787082a6f76622277e  0009-lavfi-add-avfilter_get_class-and-iteration-callbacks.patch
> > From 2eefe9b0ab73f96e6aa2de50050ba20c4f8e2da9 Mon Sep 17 00:00:00 2001
> > From: Stefano Sabatini <stefasab at gmail.com>
> > Date: Thu, 9 Aug 2012 14:59:10 +0200
> > Subject: [PATCH] lavfi: add avfilter_get_class() and iteration callbacks
> > 
> > Allow iteration over specific filter options.
> > ---
> >  libavfilter/avfilter.c |   35 +++++++++++++++++++++++++++++++++++
> >  libavfilter/avfilter.h |    6 ++++++
> >  2 files changed, 41 insertions(+), 0 deletions(-)
> > 
> > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
> > index c698d8a..9b28b90 100644
> > --- a/libavfilter/avfilter.c
> > +++ b/libavfilter/avfilter.c
> > @@ -432,13 +432,48 @@ static const char *default_filter_name(void *filter_ctx)
> >      return ctx->name ? ctx->name : ctx->filter->name;
> >  }
> >  
> > +static void *filter_child_next(void *obj, void *prev)
> > +{
> > +    AVFilterContext *ctx = obj;
> > +    if (!prev && ctx->filter && ctx->filter->priv_class && ctx->priv)
> > +        return ctx->priv;
> 
> the ctx->priv check is redudnant
> 
> except that, patch LGTM

Applied with that change, thanks for the review.
-- 
FFmpeg = Faithless Frenzy Maxi Portable EnGraver


More information about the ffmpeg-devel mailing list