[FFmpeg-devel] [PATCH 4/4] movtextdec: Don't emit errors for normal duration-end packets.
philipl at overt.org
Wed Aug 15 19:53:35 CEST 2012
On Wed, 15 Aug 2012 18:44:50 +0200
Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> On Sun, Aug 12, 2012 at 02:26:29PM -0700, Philip Langdale wrote:
> > The logic here was off. If the packet size is exactly two, then
> > it's a well-formed empty subtitle, used to mark the end of the
> > duration of the previous subtitle.
> Is that really regardless of what those 2 bytes contain?
Well, it's a little philosophical. Certainly, regardless of what
those two bytes contain, you should treat them as being 00 00.
Would you prefer an explicit check and error? It just feels a bit
weird to go to the trouble when it won't change the decoder behaviour.
More information about the ffmpeg-devel