[FFmpeg-devel] [PATCH] Fix filters permissions

Nicolas George nicolas.george at normalesup.org
Thu Aug 16 16:55:03 CEST 2012

Le decadi 30 thermidor, an CCXX, Stefano Sabatini a écrit :
> Is there a special reason for which NEG_LINESIZES is not used?

Yes: it is not really a permission in the sense: something the filter is
allowed to do with the buffer. In fact, it is the opposite of a permission:
if it is present, the filter is not allowed to assume positive linesize.

> In general I like the module/component syntax, but I won't enforce
> that upon you if you dislike it.

I have no objection, I will change it.

> why this (setting a rej_perms on an output link?)


> Regarding this, I wonder if this solution is already possible (I also
> had a decimate filter which duplicate the select logic, which I'd like
> to commit).

Yes, it is possible. In the current code, poll_frame in filters is only used
to implement poll_frame in other filters, this is never called in the whole
of ffmpeg. And since thanks to the fork avfilter_poll_frame has become
private ff_poll_frame, this should never be called in external apps either
(and they would be completely bogus with 2/3 of the filters anyway).

So there is nothing to prevent us to deprecate poll_frame and remove all
clumsy nd complex implementations.

> Looks good otherwise, of course assuming it has been tested.

I ran FATE, it covers the most useful parts of it. If you have other tests
you want to suggest, I will run them.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120816/88b0849b/attachment.asc>

More information about the ffmpeg-devel mailing list