[FFmpeg-devel] [PATCH] Fix filters permissions

Nicolas George nicolas.george at normalesup.org
Thu Aug 16 17:52:02 CEST 2012

Le decadi 30 thermidor, an CCXX, Stefano Sabatini a écrit :
> I remember I disliked the negative logic, but was the simpler way to
> do it (no need to modify all filters), dunno if it is a good idea to
> change it now (but: compatibility break).

I think we can live with this one without too much trouble.

> Feel free to push in that case, but please comment on the rej_persm in
> outlink filters remark.

I pointed you to the relevant commit:
I should have added a few words so that the link would stand out more. I
believe the commit message explains things enough:

    lavfi: use min_perms and rej_perms for out pads.
    There are several reasons for doing that:
    1. It documents the code for the reader and helps find
       inconsistencies and bugs.
    2. For rej_perms, it guarantees the change will be done
       even if the output reference can be created by several
       code paths.
    3. It can be used to predict cases where a copy will,
       or will not happen and optimize buffer allocation
       (for example not request a rare direct-rendering buffer
       from a device sink if it will be copied anyway).
    Note that a filter is still allowed to manage the permissions
    on its own without using these fields.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120816/b54eda19/attachment.asc>

More information about the ffmpeg-devel mailing list