[FFmpeg-devel] [PATCH] lavf/avio: flush when calling avio_close()
Reimar.Doeffinger at gmx.de
Thu Aug 16 20:54:06 CEST 2012
On Thu, Aug 16, 2012 at 08:45:05PM +0200, Stefano Sabatini wrote:
> On date Thursday 2012-08-16 08:16:21 +0200, Reimar Döffinger encoded:
> > On 16 Aug 2012, at 05:09, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > On Thu, Aug 16, 2012 at 01:34:48AM +0200, Stefano Sabatini wrote:
> > >> This seems the expected behavior.
> > >>
> > >> FIXME: bump micro
> > >> ---
> > >> libavformat/avio.h | 3 +++
> > >> libavformat/aviobuf.c | 1 +
> > >> 2 files changed, 4 insertions(+), 0 deletions(-)
> > >
> > > LGTM if it works and there are no objections
> > I really thought we must have discussed this before.
> > Some while ago I know I fixed some muxers that would not write out all data, and I believe it was due to this.
> > Anyone remember why we never applied such a patch?
> I don't but I confirm that it passes FATE here.
lavf: always call avio_flush in av_write_trailer.
That should have fixed it for most muxers before, though I guess it
doesn't hurt to do it on close, too.
More information about the ffmpeg-devel