[FFmpeg-devel] [PATCH] lavc/tscc: use reget_buffer.

Michael Niedermayer michaelni at gmx.at
Fri Aug 17 18:33:44 CEST 2012


On Fri, Aug 17, 2012 at 04:47:32PM +0200, Nicolas George wrote:
> The previous code would release the buffer and get it
> immediately after, assuming the contents is the same.
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavcodec/tscc.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> 
> Can someone confirm this is wrong:
> 
>     ctx->release_buffer(&pic);
>     ctx->get_buffer(&pic);
>     /* assume that pic still contains the previous data */
> 
> ?

confirmed

patch LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120817/a744788c/attachment.asc>


More information about the ffmpeg-devel mailing list