[FFmpeg-devel] [PATCH] lavfi: add volumedetect filter.

Nicolas George nicolas.george at normalesup.org
Sun Aug 19 11:40:34 CEST 2012

Le duodi 2 fructidor, an CCXX, Stefano Sabatini a écrit :
> You may consider to return a more exact value (especially useful for
> the max value) and approximate when required.

Added one decimal digit for max and mean.

> Also I'd consider more natural to return a negative value (and replace
> MAX_DB with MIN_DB = -91).

I am rather against that one: it's very easy to forget that the numbers are
negative and end up underflowing an array. I did it at least once while
writing the code, actually.

> Looks good to me otherwise, and nice work.

Thanks, pushed.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120819/9f0d6f1e/attachment.asc>

More information about the ffmpeg-devel mailing list