[FFmpeg-devel] [PATCH 1/7] lavfi: add a closed field to AVFilerLink.
stefasab at gmail.com
Tue Aug 21 20:21:53 CEST 2012
On date Tuesday 2012-08-21 09:42:25 +0200, Nicolas George encoded:
> Le quintidi 5 fructidor, an CCXX, Stefano Sabatini a écrit :
> > Nit: Set to a positive value if the link is closed ("true" is ambiguous).
> "True" is very much not ambiguous in C, it is any integer value except 0.
> But I do not mind the change.
Feel free to ignore my comment (on the other hand I'm not sure if we
should assume >0 = closed, rather than !=0, >0 seems more extensible
but this is a minor nit).
> > So I suppose this can be used also for *opening* a link?
> Provided it has been tested and work, it may become useful at tome point. It
> does not cost anything to have the API ready if the needs should arise. In
> fact, if it were not for ABI compatibility with the fork, we would let
> applications set the field directly.
> > Looks good to me, but I'm not sure which specific problem it is
> > addressing.
> When an application is no longer interested by the output of a filter (like
> ffmpeg with the -t option), but still interested by the output of another,
> it is nice to be able to stop the expensive processing for frames that will
> be immediately discarded anyway.
Thanks for the explanation. I'm fine with the patch, but Michael may
want to have a look at it and comment.
FFmpeg = Formidable and Freak Maxi Political Efficient Gymnast
More information about the ffmpeg-devel