[FFmpeg-devel] [PATCH 2/2] ffmpeg: use AV_BUFFERSRC_FLAG_PUSH.
michaelni at gmx.at
Tue Aug 21 23:54:37 CEST 2012
On Tue, Aug 21, 2012 at 09:22:33AM +0200, Nicolas George wrote:
> Le quintidi 5 fructidor, an CCXX, Michael Niedermayer a écrit :
> > Maybe i misunderstand the code but cant this break filters like
> > overlay ?
> > i mean if there would be 2 video streams in a file and a overlay
> > filter combining them. Then demuxing from this file would push frames
> > up to the overlay filter and if the 2 streams are not interleaved
> > correctly then the overlay filter would get input with mismatching
> > timestamps. Before this patch there would be buffering in the source
> Your remark is completely relevant, but you forgot that the same kind of
> thing can happen in other circumstances, especially with the split filter.
> All filters with multiple inputs must be ready to deal with that situation,
> and overlay, amongst others, is.
rethinking the push flag, maybe it would be more flexible to add a
max fifo size instead, its unrelated to above discussion though
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel