[FFmpeg-devel] [PATCH 1/7] utvideoenc: optimize and simplify mangle_rgb_planes

[Michael Niedermayer]

On Wed, Aug 22, 2012 at 10:41:49AM -0400, Derek Buitenhuis wrote:
> On 22/08/2012 10:26 AM, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavcodec/utvideoenc.c |   11 +++--------
> >  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> [...]
> 
> This should be aligned with the other two.
>                           ↓
> > +            unsigned g = src[i + 1] + 0x80;
> > +            src[i]     -= g;
> > +            src[i + 2] -= g;
> 
> I think Jan prefers variables declared at the beginning of the function, but I do not
> know if this adversely affects performance.

changed, this function should be written in SIMD anyway


> 
> Looks OK, in general.

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120822/14ba65fa/attachment.asc>