[FFmpeg-devel] [PATCH 5/7] utvideoenc: drop step

Derek Buitenhuis derek.buitenhuis at gmail.com
Wed Aug 22 17:08:04 CEST 2012


On 22/08/2012 10:26 AM, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavcodec/utvideoenc.c |   30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)

[...]

>      for (j = 0; j < height; j++) {
> -        for (i = 0; i < width * step; i += step)
> +        for (i = 0; i < width; i ++)

Stray space.

>      prev = 0x80; /* Set the initial value */
>      for (j = 0; j < height; j++) {
> -        for (i = 0; i < width * step; i += step) {
> +        for (i = 0; i < width; i ++) {

Ditto.

>      /* First line uses left neighbour prediction */
>      prev = 0x80; /* Set the initial value */
> -    for (i = 0; i < width * step; i += step) {
> +    for (i = 0; i < width; i ++) {

Ditto.

> -    for (i = step; i < width * step; i += step) {
> +    for (i = 1; i < width; i ++) {

Ditto.

>      /* Rest of the coded part uses median prediction */
>      for (j = 2; j < height; j++) {
> -        for (i = 0; i < width * step; i += step) {
> +        for (i = 0; i < width; i ++) {

Ditto.

Otherwise, looks OK.

- Derek


More information about the ffmpeg-devel mailing list