[FFmpeg-devel] [PATCH] opt: implement av_opt_set_from_string().

[Michael Niedermayer]

On Fri, Aug 24, 2012 at 12:45:54PM +0200, Nicolas George wrote:
> L'octidi 8 fructidor, an CCXX, Stefano Sabatini a écrit :
> > Well I still can foresee some cases where this is not the case
> > (e.g. real person names as keys - admittedly not very realistic).
> 
> I think we can exclude that case.
> 
> > Also the keys might be used in different contexts
> > (e.g. "bikeshed:color=pink", depending on the context/separators
> > adopted this might be parsed uncorrectly if not quoted like
> > "'bikeshed:color'=pink").
> 
> There are still a lot of chars that can serve as context separators without
> risking any conflict with reasonable key=value and field separator: '/' and
> '.' are quite obvious choices, '>' is used by CSS, etc.
> 
> > If you consider the additional complexity not worth the feature,
> 
> I think so, but I would like some outside advice. Maybe look at the current
> code of parse_key_value_pair, and try to guess in advance where various
> cases of invalid input will fail and the error message that will result: if
> you get it wrong, then the code is probably too complicated :)

I think we should generally avoid things that will need escaping even
when escaping is supported

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120824/233c439a/attachment.asc>