[FFmpeg-devel] [PATCH] cllc: Pad swapepd buffer
Reimar.Doeffinger at gmx.de
Sun Aug 26 13:11:03 CEST 2012
On Sun, Aug 26, 2012 at 10:14:11AM +0000, Paul B Mahol wrote:
> On 8/25/12, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> > On 25/08/2012 6:21 PM, Reimar Doeffinger wrote:
> >>> There's no benefit to using it.
> >>> It also simplifies the allocation failure handling and can be faster.
> > I don't see how it could possible be faster. It adds an extra memset, for
> > one thing.
> > If I were to switch, I'd likely switch to av_fast_malloc. I don't really see
> > a point in switching other than for the sake of bikeshed.
> There is av_fast_padded_mallocz().
Which shouldn't be necessary and it's only an issue because the wrong
value is used for the allocation for no good reason I can see.
I'll send a patch.
> Switch only if there is measurable speed gain.
To measure that you'd have to implement it, then you could just
do the change to the semantically correct version right away.
More information about the ffmpeg-devel