[FFmpeg-devel] [PATCH] lavu: add snprintf(), vsnprint() and strtod() replacements for MS runtime.

Michael Niedermayer michaelni at gmx.at
Mon Aug 27 00:33:56 CEST 2012

On Sun, Aug 26, 2012 at 07:23:50AM -0700, Ronald S. Bultje wrote:
> From: "Ronald S. Bultje" <rsbultje at gmail.com>

> + * This file is part of Libav.

This is not correct

> +int avpriv_vsnprintf(char *restrict s, size_t n, const char *restrict fmt,
> +                     va_list ap)
> +{
> +    int ret;
> +
> +    if (n == 0)
> +        return 0;
> +    else if (n > INT_MAX)
> +        return AVERROR(EOVERFLOW);

EOVERFLOW is not available on some versions of windows, please choose
a different error code.
see doc/errno.txt

also please make sure your patches can be applied cleanly with
git am
my concern here is primarely that if they do not apply cleanly then
most likely they have not been tested with ffmpeg git master which
is not good.

but overall, this is nice work


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120827/9a0084c1/attachment.asc>

More information about the ffmpeg-devel mailing list