[FFmpeg-devel] [PATCH] lavfi/af_atempo: use av_malloc for rDFT buffers.
pkoshevoy at gmail.com
Wed Aug 29 02:56:07 CEST 2012
On 08/28/2012 10:58 AM, Nicolas George wrote:
> Le duodi 12 fructidor, an CCXX, Reimar Döffinger a écrit :
>> I can't see why the data for the other cases would need to be preserved?
>> So you could just make all use this code.
> The other fields seem to be filled progressively by samples from the input.
> Of course, currently lavfi does not support reconfiguration, but it seems
> that the design is specifically made to support it.
> I would like Pavel's advice on that, though.
You can switch everything to RE_MALLOC...
If you look at the second-to-last line of yae_reset(..) it calls yae_clear,
which resets both fragments to initial state. So, all prior data is dumped.
The only reason I used realloc was to help reduce memory fragmentation.
Although, that's probably not an issue for this filter.
>> Btw. the double () around field_size looks a bit ugly.
> It is indeed not necessary for a single argument. I will remove it before
> pushing anything.
More information about the ffmpeg-devel