[FFmpeg-devel] [PATCH]Clarify that there are two different "passlogfile" options
stefasab at gmail.com
Wed Aug 29 17:00:27 CEST 2012
On date Wednesday 2012-08-29 13:57:56 +0000, Carl Eugen Hoyos encoded:
> Stefano Sabatini <stefasab <at> gmail.com> writes:
> > So I'd expect the stats file to have the specified name in
> > logfilename. What am I missing?
> Probably nothing (which is the reason I don't like it if
> console output is attached instead of posted in the ticket).
I can't see any evidence from the attachments that the file was
overwritten, and current code seems just correct (without testing).
> Should the documentation patch be added to old versions or
> the fix back-ported?
> (And what happens if x264 changes its -stats syntax?)
That's why I believe such codec specific hacks should be avoided.
Ideally we should avoid to use an option to mask a codec specific
option, with all the glitches/bugs deriving from it (the
x264/passlogfile/stats thing has been indeed a continuous source of
But even with the hack, I don't think that x264 will do anything
special with the passlogfilename, e.g. like parsing it, stripping the
index at the end and wiping out user data, so documentation should not
need to be updated.
If there was a bug, we could consider to backport it to old versions
(but 0.7 is pretty old and I'm not even sure we are still supporting
Sorry for bothering ;-).
FFmpeg = Freak and Friendly Muttering Pacific Elected Gospel
More information about the ffmpeg-devel